build: enable big toc for release builds in AIX #7508
Conversation
|
Does that mean the |
|
@bnoordhuis - I will check and get back on this. |
AIX linker has a table of contents with default size 64K The recent code inclusions in V8 brings in lot of new symbols which necessitates to increase this default. Please note that the debug build already has this flag
|
@bnoordhuis - you are right, the -bbigtoc flag in node.gyp is meant for the same purpose, but covers only the building of node. Now that the same is introduced in common.gypi, we don't need it in node.gyp any more. Please note however, that the -bE:<(PRODUCT_DIR)/node.exp needs to be retained. And hence I have revised my changes. Please review and let me know. |
|
LGTM |
|
CI run green, landing |
AIX linker has a table of contents with default size 64K The recent code inclusions in V8 brings in lot of new symbols which necessitates to increase this default. Please note that the debug build already has this flag Fixes: #7500 PR-URL: #7508 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
AIX CI run to validate after landing: https://ci.nodejs.org/job/node-test-commit-aix/242/. We have identified that there is a new issue, but want to validate through CI that the toc issue is resolved. |
|
Ok, toc issue resolve, and see new issue, will open separate issue for that one closing |
AIX linker has a table of contents with default size 64K The recent code inclusions in V8 brings in lot of new symbols which necessitates to increase this default. Please note that the debug build already has this flag Fixes: #7500 PR-URL: #7508 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
@mhdawson lts? |
|
needs to land if #6734 lands |
|
Id say if needed due to other commits, yes, otherwise if it applies cleanly then it probably makes sense just to avoid problems in the future. |
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesNOTE: There is an outstanding issue in AIX build (#7500) - build fail due to 787eddf . The tests are conducted with this change removed.
Affected core subsystem(s)
Description of change
Issue #7500
AIX linker has a table of contents with default size 64K
The recent code inclusions in V8 brings in lot of new
symbols which necessitates to increase this default.
Please note that the debug build already has this flag